2.517 Released

[Rak'kar]

Please use the latest version to fix your compile problems.  If you don't want to upgrade you can fix them yourself, as they are quite trivial.  The easiest way is to selectively download the files you need from source control.

[Oliver Smith]

Need a sticky in this forum telling us how to get at it Incidentlly, it happens I use Source Off Site, could I point that directly at your vault server for read-only access? Or is it web only?

[Rak'kar]

I don't know.  Just try it I guess.

[Oliver Smith]

Ok, *cough*

Need a sticky in this forum telling us how to get at it

Don't make me admit I couldn't find the instructions!

DOH!

[Rak'kar]

Oh, sorry I thought you were asking how to get the latest version of RakNet.

The source control instructions are here:

http://www.rakkarsoft.com/raknet/forum/index.php?topic=2.0

[Oliver Smith]

Some notes on CreatePatch.cpp:

- redefinition of "MIN", suggest you wrap with

#ifndef MIN
# define MIN ...
#endif

or #include <algorithm> and use std::min(...)

- off_t is signed, use size_t if you want unsigned to eliminate sign/unsign warnings

- "unsigned newsize" (etc). Unsigned what? Be aware that while VS allows this it's very port-problematic, including vs Win32 and Win64.

- Oliver

[Oliver Smith]

   y=y/256;buf[1]=y%256;y-=buf[1];
   y=y/256;buf[2]=y%256;y-=buf[2];

OUCH! Divide AND modulo! Woot! WORK THAT CPU BABY Remembering that modulo is usually implemented as

while ( VAL > LIM )
  VAL -= LIM ;

even in Microcode. So perhaps better written as

Code: [Select]

for ( int i =0 ; i < 8 ; ++i )
 {
   // Copy lower 8 bits
   buf[i] = y & 0x255 ;
   // And shift 8 bits down
   y >>= 8 ;
 }

or

  buf[0] = y & 0xff ; y >>= 8 ;
  buf[1] = y & 0xff ; y >>= 8 ;
  buf[2] = y & 0xff ; y >>= 8 ;
  buf[3] = y & 0xff ; y >>= 8 ;
  buf[4] = y & 0xff ; y >>= 8 ;
  buf[5] = y & 0xff ; y >>= 8 ;
  buf[6] = y & 0xff ; y >>= 8 ;
  buf[7] = y & 0x7f ; y >>= 8 ;


- Ol

[Oliver Smith]

Any time you're setting > 32 bytes to 0, calling memset is a good bet:

CreatePatch.cpp:130
   for(i=0;i<256;i++) buckets[ i ]=0;

vs

                 memset(buckets, 0, sizeof(buckets));

[Rak'kar]

Thanks for the excellent posts.  I didn't write most of that code but will optimize it.

[ChildeHarold]

Trying to update to Raknet 2.517 I got a compiler error:

VoiceComm.obj : error LNK2001: Nichtaufgelöstes externes Symbol "public: char * __thiscall PlayerID::ToString(void)const " (?ToString@PlayerID@@$$FQBEPADXZ)
Release/RakNetPlugin.dll : fatal error LNK1120: 1 unaufgelöste externe Verweise

[Rak'kar]

Rebuild all.

[ChildeHarold]

the problem remains...

[Rak'kar]

The function now takes a boolean input parameter.